Skip to content

CI: Pin NumPy version #18993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

TomAugspurger
Copy link
Contributor

closes #18992

This should fail.

@jreback
Copy link
Contributor

jreback commented Dec 29, 2017

hmm, there is a compat version of numba that should be ok on 3.5/1.10.

@codecov
Copy link

codecov bot commented Dec 29, 2017

Codecov Report

Merging #18993 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18993      +/-   ##
==========================================
- Coverage   91.58%   91.56%   -0.03%     
==========================================
  Files         150      150              
  Lines       48972    48972              
==========================================
- Hits        44851    44839      -12     
- Misses       4121     4133      +12
Flag Coverage Δ
#multiple 89.92% <ø> (-0.03%) ⬇️
#single 41.72% <ø> (ø) ⬆️
Impacted Files Coverage Δ
pandas/plotting/_converter.py 65.22% <0%> (-1.74%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c1071b...620216d. Read the comment docs.

@jreback
Copy link
Contributor

jreback commented Dec 29, 2017

so #18994 actually makes this error show up (and that is why I think you have it on 0.22.x branch, its using the latest conda), while on master I pinned to 4.3.30 which I thought was causing the issues. https://travis-ci.org/pandas-dev/pandas/jobs/322965133.

@jreback
Copy link
Contributor

jreback commented Dec 29, 2017

just going to skip for old numpy for now on those tests. i don't think its a big deal.

you can cherry-pick the commit to 0.22.x

@jreback
Copy link
Contributor

jreback commented Dec 29, 2017

closed in favor of #18995

@jreback jreback closed this Dec 29, 2017
@TomAugspurger TomAugspurger deleted the ci-fixup branch December 29, 2017 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: NumPy is being upgraded
2 participants